[Discover] Update async search response type #8781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
joshuali925
reviewed
Nov 1, 2024
src/plugins/query_enhancements/server/search/ppl_async_search_strategy.ts
Outdated
Show resolved
Hide resolved
src/plugins/query_enhancements/server/search/ppl_async_search_strategy.ts
Show resolved
Hide resolved
Signed-off-by: Shenoy Pratik <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8781 +/- ##
=======================================
Coverage 60.75% 60.75%
=======================================
Files 3798 3798
Lines 90690 90690
Branches 14277 14277
=======================================
Hits 55101 55101
Misses 32090 32090
Partials 3499 3499
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AMoo-Miki
approved these changes
Nov 1, 2024
ananzh
approved these changes
Nov 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
* update async search reponse type Signed-off-by: Shenoy Pratik <[email protected]> * Changeset file for PR #8781 created/updated * remove explicit type declaration Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit affd265) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/OpenSearch-Dashboards
that referenced
this pull request
Nov 1, 2024
* update async search reponse type Signed-off-by: Shenoy Pratik <[email protected]> * Changeset file for PR opensearch-project#8781 created/updated * remove explicit type declaration Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
abbyhu2000
pushed a commit
that referenced
this pull request
Nov 12, 2024
* update async search reponse type * Changeset file for PR #8781 created/updated * remove explicit type declaration --------- (cherry picked from commit affd265) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update async search response type
Issues Resolved
This is a fast followup PR for #8777 based on the comment #8777 (comment). Adds a type check on response of jobs API in async search strategies.
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration